From 0fef8539f4deedfde2f4c5d7563f8219b44683f1 Mon Sep 17 00:00:00 2001
From: root <root@rspade.framework.dev.hanson.xyz>
Date: Thu, 30 Oct 2025 22:57:19 +0000
Subject: [PATCH] Fix LayoutLocalAssets rule to only check CSS and JS files
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 .../LayoutLocalAssets_CodeQualityRule.php     | 23 ++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/app/RSpade/CodeQuality/Rules/Blade/LayoutLocalAssets_CodeQualityRule.php b/app/RSpade/CodeQuality/Rules/Blade/LayoutLocalAssets_CodeQualityRule.php
index dc31c3e32..4384f6bb8 100755
--- a/app/RSpade/CodeQuality/Rules/Blade/LayoutLocalAssets_CodeQualityRule.php
+++ b/app/RSpade/CodeQuality/Rules/Blade/LayoutLocalAssets_CodeQualityRule.php
@@ -18,7 +18,7 @@ class LayoutLocalAssets_CodeQualityRule extends CodeQualityRule_Abstract
 
     public function get_description(): string
     {
-        return 'Enforces that local assets in layout files are included via bundle definitions, not hardcoded link/script tags';
+        return 'Enforces that local CSS and JavaScript files in layout files are included via bundle definitions, not hardcoded <link rel="stylesheet"> or <script src> tags';
     }
 
     public function get_file_patterns(): array
@@ -71,8 +71,25 @@ class LayoutLocalAssets_CodeQualityRule extends CodeQualityRule_Abstract
         foreach ($lines as $line_num => $line) {
             $line_number = $line_num + 1;
 
-            // Check for <link rel="stylesheet" with local href
-            if (preg_match('/<link\s+[^>]*href=["\'](\/[^"\']*)["\'][^>]*>/i', $line, $matches)) {
+            // Check for <link rel="stylesheet" with local href (CSS only, not favicons or other link types)
+            if (preg_match('/<link\s+[^>]*rel=["\']stylesheet["\'][^>]*href=["\'](\/[^"\']*)["\'][^>]*>/i', $line, $matches)) {
+                $href = $matches[1];
+
+                // Skip if it's a CDN/external URL (contains http)
+                if (str_contains(strtolower($line), 'http')) {
+                    continue;
+                }
+
+                $violations[] = [
+                    'type' => 'local_css',
+                    'line' => $line_number,
+                    'code' => trim($line),
+                    'path' => $href
+                ];
+            }
+
+            // Also check reversed attribute order: href before rel
+            if (preg_match('/<link\s+[^>]*href=["\'](\/[^"\']*)["\'][^>]*rel=["\']stylesheet["\'][^>]*>/i', $line, $matches)) {
                 $href = $matches[1];
 
                 // Skip if it's a CDN/external URL (contains http)