Fix code quality violations and enhance ROUTE-EXISTS-01 rule
Implement JQHTML function cache ID system and fix bundle compilation Implement underscore prefix for system tables Fix JS syntax linter to support decorators and grant exception to Task system SPA: Update planning docs and wishlists with remaining features SPA: Document Navigation API abandonment and future enhancements Implement SPA browser integration with History API (Phase 1) Convert contacts view page to SPA action Convert clients pages to SPA actions and document conversion procedure SPA: Merge GET parameters and update documentation Implement SPA route URL generation in JavaScript and PHP Implement SPA bootstrap controller architecture Add SPA routing manual page (rsx:man spa) Add SPA routing documentation to CLAUDE.md Phase 4 Complete: Client-side SPA routing implementation Update get_routes() consumers for unified route structure Complete SPA Phase 3: PHP-side route type detection and is_spa flag Restore unified routes structure and Manifest_Query class Refactor route indexing and add SPA infrastructure Phase 3 Complete: SPA route registration in manifest Implement SPA Phase 2: Extract router code and test decorators Rename Jqhtml_Component to Component and complete SPA foundation setup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -64,7 +64,7 @@ class JqhtmlComponentNaming_CodeQualityRule extends CodeQualityRule_Abstract
|
||||
$this->check_jqhtml_file($file_path, $contents);
|
||||
}
|
||||
|
||||
// Check .js files for classes extending Jqhtml_Component
|
||||
// Check .js files for classes extending Component
|
||||
if (str_ends_with($file_path, '.js')) {
|
||||
$this->check_javascript_file($file_path, $contents, $metadata);
|
||||
}
|
||||
@@ -101,7 +101,7 @@ class JqhtmlComponentNaming_CodeQualityRule extends CodeQualityRule_Abstract
|
||||
}
|
||||
|
||||
/**
|
||||
* Check JavaScript files for Jqhtml_Component subclasses
|
||||
* Check JavaScript files for Component subclasses
|
||||
*/
|
||||
private function check_javascript_file(string $file_path, string $contents, array $metadata = []): void
|
||||
{
|
||||
@@ -131,7 +131,7 @@ class JqhtmlComponentNaming_CodeQualityRule extends CodeQualityRule_Abstract
|
||||
// Check each class to see if it's a JQHTML component
|
||||
foreach ($class_definitions as $class_name => $line_num) {
|
||||
// Use Manifest to check if this is a JQHTML component (handles indirect inheritance)
|
||||
if (Manifest::js_is_subclass_of($class_name, 'Jqhtml_Component')) {
|
||||
if (Manifest::js_is_subclass_of($class_name, 'Component')) {
|
||||
// Check if first character is not uppercase
|
||||
if (!ctype_upper($class_name[0])) {
|
||||
$this->add_violation(
|
||||
|
||||
Reference in New Issue
Block a user