Files

root 77b4d10af8 Refactor filename naming system and apply convention-based renames

Standardize settings file naming and relocate documentation files
Fix code quality violations from rsx:check
Reorganize user_management directory into logical subdirectories
Move Quill Bundle to core and align with Tom Select pattern
Simplify Site Settings page to focus on core site information
Complete Phase 5: Multi-tenant authentication with login flow and site selection
Add route query parameter rule and synchronize filename validation logic
Fix critical bug in UpdateNpmCommand causing missing JavaScript stubs
Implement filename convention rule and resolve VS Code auto-rename conflict
Implement js-sanitizer RPC server to eliminate 900+ Node.js process spawns
Implement RPC server architecture for JavaScript parsing
WIP: Add RPC server infrastructure for JS parsing (partial implementation)
Update jqhtml terminology from destroy to stop, fix datagrid DOM preservation
Add JQHTML-CLASS-01 rule and fix redundant class names
Improve code quality rules and resolve violations
Remove legacy fatal error format in favor of unified 'fatal' error type
Filter internal keys from window.rsxapp output
Update button styling and comprehensive form/modal documentation
Add conditional fly-in animation for modals
Fix non-deterministic bundle compilation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-11-13 19:10:02 +00:00

2.6 KiB

Executable File

Raw Blame History

Code Quality Support Classes

FileSanitizer - RPC Server Architecture

Overview

JavaScript sanitization uses long-running Node.js RPC server via Unix socket to avoid spawning 1000+ Node processes during manifest build.

Components

FileSanitizer.php - PHP client, manages server lifecycle
js-sanitizer-server.js - Node.js RPC server, processes batch sanitization requests
js-sanitizer.js - Legacy single-file sanitizer (kept in /bin/ for compatibility)

Server Lifecycle

Lazy start: Server spawns on first JS file sanitization during code quality checks
Startup: Checks for stale socket, force-kills if found, starts fresh server
Wait: Polls socket with ping (50ms intervals, 10s max), fatal error if timeout
Usage: All JS sanitization during checks goes through RPC
Shutdown: Graceful shutdown when code quality checks complete (registered shutdown handler)

Socket

Path: storage/rsx-tmp/js-sanitizer-server.sock
Protocol: Line-delimited JSON over Unix domain socket

RPC Methods

ping → "pong" - Health check
sanitize → {file: {status, sanitized, original_lines}, ...} - Batch sanitize multiple files
shutdown → Graceful server termination

PHP API

FileSanitizer::sanitize_javascript($file_path);  // Auto-starts RPC server, uses cache
FileSanitizer::start_rpc_server();               // Lazy init, auto-called
FileSanitizer::stop_rpc_server($force);          // Clean shutdown

Force Parameter

stop_rpc_server($force = false):

false (default): Send shutdown command, return immediately
true: Send shutdown + wait + SIGTERM if needed (used for stale server cleanup)

Cache Integration

Cache checked before RPC call - only files with stale cache sent to server for sanitization. Cache directory: storage/rsx-tmp/cache/js-sanitized/

Error Handling

Server failure → fatal error (no fallback). Server must start or code quality check fails.

Sanitization Process

Remove comments: Uses decomment npm package to strip comments while preserving line numbers
Replace string contents: Parses with Acorn AST parser, replaces string literal contents with spaces
Preserve structure: Maintains line/column positions for accurate violation reporting

Performance Impact

Before RPC: 900+ Node.js process spawns during manifest build (~30-60s overhead) After RPC: Single Node.js process, reused across all sanitizations (~1-2s startup overhead)

Parallel to JS Parser

This architecture mirrors the JS parser RPC server pattern. See /app/RSpade/Core/JavaScript/CLAUDE.md for detailed RPC pattern documentation.

2.6 KiB Executable File Raw Blame History