rspade_system/app/RSpade/CodeQuality/Rules/JavaScript/JqhtmlOnLoadData_CodeQualityRule.php

<?php

namespace App\RSpade\CodeQuality\Rules\JavaScript;

use App\RSpade\CodeQuality\Rules\CodeQualityRule_Abstract;
use App\RSpade\CodeQuality\Support\FileSanitizer;
use App\RSpade\Core\Manifest\Manifest;

class JqhtmlOnLoadData_CodeQualityRule extends CodeQualityRule_Abstract
{
    public function get_id(): string
    {
        return 'JQHTML-LOAD-02';
    }

    public function get_name(): string
    {
        return 'JQHTML on_load Data Assignment Check';
    }

    public function get_description(): string
    {
        return 'on_load() method should only set this.data properties, not other this. properties';
    }

    public function get_file_patterns(): array
    {
        return ['*.js'];
    }

    public function get_default_severity(): string
    {
        return 'high';
    }

    /**
     * Check that on_load methods only set this.data properties
     */
    public function check(string $file_path, string $contents, array $metadata = []): void
    {
        // Skip vendor and node_modules
        if (str_contains($file_path, '/vendor/') || str_contains($file_path, '/node_modules/')) {
            return;
        }

        // Skip CodeQuality directory
        if (str_contains($file_path, '/CodeQuality/')) {
            return;
        }

        // Get sanitized content
        $sanitized_data = FileSanitizer::sanitize_javascript($file_path);
        $content = $sanitized_data['content'];

        // Get JavaScript class from manifest metadata
        $js_classes = [];
        if (isset($metadata['class']) && isset($metadata['extension']) && $metadata['extension'] === 'js') {
            $js_classes = [$metadata['class']];
        }

        // If no classes in metadata, try to extract from source
        if (empty($js_classes)) {
            return;
        }

        // Check each class to see if it's a JQHTML component
        foreach ($js_classes as $class_name) {
            // Use Manifest to check inheritance (handles indirect inheritance)
            if (!Manifest::js_is_subclass_of($class_name, 'Jqhtml_Component') &&
                !Manifest::js_is_subclass_of($class_name, 'Component')) {
                continue;
            }

            // Now find WHERE this class is in the source for extraction
            // @META-INHERIT-01-EXCEPTION - Finding class position with PREG_OFFSET_CAPTURE to extract method bodies
            if (!preg_match('/class\s+' . preg_quote($class_name, '/') . '\s+extends\s+\w+\s*\{/i', $content, $class_match, PREG_OFFSET_CAPTURE)) {
                continue;
            }
            $class_start = $class_match[0][1];

            // Find the class content
            $brace_count = 0;
            $in_class = false;
            $class_content = '';
            $pos = $class_start;

            while ($pos < strlen($content)) {
                $char = $content[$pos];

                if ($char === '{') {
                    $brace_count++;
                    $in_class = true;
                } elseif ($char === '}') {
                    $brace_count--;
                    if ($brace_count === 0 && $in_class) {
                        $class_content = substr($content, $class_start, $pos - $class_start + 1);
                        break;
                    }
                }
                $pos++;
            }

            if (empty($class_content)) {
                continue;
            }

            // Look for on_load method
            if (!preg_match('/(?:async\s+)?on_load\s*\([^)]*\)\s*\{/i', $class_content, $method_match, PREG_OFFSET_CAPTURE)) {
                continue; // No on_load method
            }

            $method_start = $method_match[0][1];

            // Extract the on_load method body
            $method_pos = $class_start + $method_start;
            $method_brace_count = 0;
            $in_method = false;
            $method_content = '';
            $pos = $method_pos;

            while ($pos < strlen($content)) {
                $char = $content[$pos];

                if ($char === '{') {
                    $method_brace_count++;
                    $in_method = true;
                } elseif ($char === '}') {
                    $method_brace_count--;
                    if ($method_brace_count === 0 && $in_method) {
                        $method_content = substr($content, $method_pos, $pos - $method_pos + 1);
                        break;
                    }
                }
                $pos++;
            }

            if (empty($method_content)) {
                continue;
            }

            // Check for this. property assignments
            $lines = explode("\n", $method_content);
            $line_offset = substr_count(substr($content, 0, $method_pos), "\n");

            foreach ($lines as $line_num => $line) {
                $actual_line_number = $line_offset + $line_num + 1;
                $trimmed = trim($line);

                // Skip comments
                if (str_starts_with($trimmed, '//') || str_starts_with($trimmed, '*')) {
                    continue;
                }

                // Check for this.property = value patterns
                // Match: this.something =
                // But not: this.data.something =
                if (preg_match('/\bthis\.(\w+)\s*=/', $line, $matches)) {
                    $property_name = $matches[1];

                    // Allow this.data assignments
                    if ($property_name === 'data') {
                        continue;
                    }

                    // Check if it's a sub-property of data (this.data.something)
                    if (preg_match('/\bthis\.data\.\w+/', $line)) {
                        continue;
                    }

                    // Check for destructuring into this.data
                    if (preg_match('/\bthis\.data\s*=\s*\{.*' . preg_quote($property_name, '/') . '/', $line)) {
                        continue;
                    }

                    $this->add_violation(
                        $file_path,
                        $actual_line_number,
                        "Setting 'this.{$property_name}' in on_load() method of class '{$class_name}'. The on_load() method should only update this.data properties.",
                        trim($line),
                        "Change to 'this.data.{$property_name} = ...' or move to on_create() if it's component state.",
                        'high'
                    );
                }

                // Also check for Object.assign or similar patterns that set this properties
                if (preg_match('/Object\.assign\s*\(\s*this\s*(?!\.data)/', $line)) {
                    $this->add_violation(
                        $file_path,
                        $actual_line_number,
                        "Using Object.assign on 'this' in on_load() method of class '{$class_name}'. The on_load() method should only update this.data.",
                        trim($line),
                        "Use 'Object.assign(this.data, ...)' instead, or move to on_create() for component state.",
                        'high'
                    );
                }
            }
        }
    }
}