Revert "No more main thread SQL"

This reverts commit 4de891b459.

Async writes are a bad idea.

mobile/src/main/java/be/mygod/vpnhotspot/client/ClientsFragment.kt

@@ -140,9 +140,7 @@ class ClientsFragment : Fragment(), MainScope by MainScope.Supervisor() {
                     val wasWorking = TrafficRecorder.isWorking(client.mac)
                     client.obtainRecord().apply {
                         blocked = !blocked
-                        GlobalScope.launch(Dispatchers.Main, CoroutineStart.UNDISPATCHED) {
-                            AppDatabase.instance.clientRecordDao.update(this@apply)
-                        }
+                        AppDatabase.instance.clientRecordDao.update(this)
                     }
                     IpNeighbourMonitor.instance?.flush()
                     if (!wasWorking && item.itemId == R.id.block) {

mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/TrafficRecorder.kt

@@ -10,10 +10,6 @@ import be.mygod.vpnhotspot.util.Event2
 import be.mygod.vpnhotspot.util.RootSession
 import be.mygod.vpnhotspot.util.parseNumericAddress
 import be.mygod.vpnhotspot.widget.SmartSnackbar
-import kotlinx.coroutines.CoroutineStart
-import kotlinx.coroutines.Dispatchers
-import kotlinx.coroutines.GlobalScope
-import kotlinx.coroutines.launch
 import timber.log.Timber
 import java.net.InetAddress
 import java.util.concurrent.TimeUnit
@@ -29,9 +25,7 @@ object TrafficRecorder {
 
     fun register(ip: InetAddress, downstream: String, mac: Long) {
         val record = TrafficRecord(mac = mac, ip = ip, downstream = downstream)
-        GlobalScope.launch(Dispatchers.Main, CoroutineStart.UNDISPATCHED) {
         AppDatabase.instance.trafficRecordDao.insert(record)
-        }
         synchronized(this) {
             DebugHelper.log(TAG, "Registering $ip%$downstream")
             check(records.put(Pair(ip, downstream), record) == null)
@@ -123,10 +117,8 @@ object TrafficRecorder {
             check(record.sentBytes >= 0)
             check(record.receivedPackets >= 0)
             check(record.receivedBytes >= 0)
-            GlobalScope.launch(Dispatchers.Main, CoroutineStart.UNDISPATCHED) {
             AppDatabase.instance.trafficRecordDao.insert(record)
         }
-        }
         foregroundListeners(records.values, oldRecords)
     }
     fun update(timeout: Boolean = false) {

mobile/src/main/java/be/mygod/vpnhotspot/room/AppDatabase.kt

@@ -19,6 +19,7 @@ abstract class AppDatabase : RoomDatabase() {
                     .addMigrations(
                             Migration2
                     )
+                    .allowMainThreadQueries()
                     .build()
         }
     }

mobile/src/main/java/be/mygod/vpnhotspot/room/ClientRecord.kt

@@ -2,9 +2,6 @@ package be.mygod.vpnhotspot.room
 
 import androidx.lifecycle.LiveData
 import androidx.room.*
-import kotlinx.coroutines.Dispatchers
-import kotlinx.coroutines.GlobalScope
-import kotlinx.coroutines.async
 import kotlinx.coroutines.runBlocking
 
 @Entity
@@ -24,17 +21,13 @@ data class ClientRecord(@PrimaryKey
         abstract fun lookupSync(mac: Long): LiveData<ClientRecord>
 
         @Insert(onConflict = OnConflictStrategy.REPLACE)
-        protected abstract suspend fun updateInternal(value: ClientRecord): Long
-        suspend fun update(value: ClientRecord) = check(updateInternal(value) == value.mac)
+        protected abstract fun updateInternal(value: ClientRecord): Long
+        fun update(value: ClientRecord) = check(updateInternal(value) == value.mac)
 
         @Transaction
-        protected open fun upsertSync(mac: Long, operation: ClientRecord.() -> Unit) = runBlocking {
-            lookupOrDefault(mac).apply {
+        open fun upsert(mac: Long, operation: ClientRecord.() -> Unit) = runBlocking { lookupOrDefault(mac) }.apply {
             operation()
             update(this)
         }
     }
-        fun upsert(mac: Long, operation: ClientRecord.() -> Unit) =
-                GlobalScope.async(Dispatchers.IO) { upsertSync(mac, operation) }
-    }
 }

mobile/src/main/java/be/mygod/vpnhotspot/room/TrafficRecord.kt

@@ -41,8 +41,8 @@ data class TrafficRecord(
     @androidx.room.Dao
     abstract class Dao {
         @Insert
-        protected abstract suspend fun insertInternal(value: TrafficRecord): Long
-        suspend fun insert(value: TrafficRecord) {
+        protected abstract fun insertInternal(value: TrafficRecord): Long
+        fun insert(value: TrafficRecord) {
             check(value.id == null)
             value.id = insertInternal(value)
         }