From 3fead73a12efc827469f67f3c5a8617304d41d21 Mon Sep 17 00:00:00 2001
From: Mygod <contact-git@mygod.be>
Date: Thu, 23 Jul 2020 07:50:38 +0800
Subject: [PATCH] Refine logging

---
 .../src/main/java/be/mygod/librootkotlinx/RootServer.kt  | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/mobile/src/main/java/be/mygod/librootkotlinx/RootServer.kt b/mobile/src/main/java/be/mygod/librootkotlinx/RootServer.kt
index 59c04b6c..da24f3bd 100644
--- a/mobile/src/main/java/be/mygod/librootkotlinx/RootServer.kt
+++ b/mobile/src/main/java/be/mygod/librootkotlinx/RootServer.kt
@@ -194,11 +194,10 @@ class RootServer @JvmOverloads constructor(private val warnLogger: (String) -> U
                 break
             }
             val result = input.readByte()
+            Timber.i("Received callback #$index: $result")
             val callback = mutex.synchronized {
-                callbackLookup[index]!!.also {
-                    if (it.shouldRemove(result).also { shouldRemove ->
-                                Timber.i("$index($result) should remove $it: $shouldRemove")
-                            }) {
+                (callbackLookup[index] ?: error("Empty callback #$index")).also {
+                    if (it.shouldRemove(result)) {
                         callbackLookup.remove(index)
                         it.active = false
                     }
@@ -277,6 +276,7 @@ class RootServer @JvmOverloads constructor(private val warnLogger: (String) -> U
         val callback = Callback.Ordinary(this, counter, classLoader, future as CompletableDeferred<Parcelable?>)
         mutex.withLock {
             if (active) {
+                Timber.i("Register callback #$counter $command")
                 callbackLookup[counter] = callback
                 sendLocked(command)
             } else future.cancel()
@@ -307,6 +307,7 @@ class RootServer @JvmOverloads constructor(private val warnLogger: (String) -> U
         val callback = Callback.Channel(this@RootServer, counter, classLoader, this as SendChannel<Parcelable?>)
         mutex.withLock {
             if (active) {
+                Timber.i("Register callback #$counter $command")
                 callbackLookup[counter] = callback
                 sendLocked(command)
             } else callback.finish.cancel()