Fix race in LOHS

2019-10-25 05:12:38 +08:00
parent 2504be45cf
commit 59036ca80d
1 changed files with 5 additions and 6 deletions
--- a/mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt
+++ b/mobile/src/main/java/be/mygod/vpnhotspot/LocalOnlyHotspotService.kt
@@ -37,13 +37,12 @@ class LocalOnlyHotspotService : IpNeighbourMonitoringService(), CoroutineScope {

        val configuration get() = reservation?.wifiConfiguration

-        fun stop() = when (iface) {
-            null -> { } // stopped
-            "" -> {
-                WifiApManager.cancelLocalOnlyHotspotRequest()
-                reservation?.close() ?: stopService()
+        fun stop() {
+            when (iface) {
+                null -> return  // stopped
+                "" -> WifiApManager.cancelLocalOnlyHotspotRequest()
            }
-            else -> reservation!!.close()
+            reservation?.close() ?: stopService()
        }
    }