brianhansonxyz/vpnhotspotmod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refine code

Browse Source
This commit is contained in:
Mygod
2018-10-04 16:45:44 +08:00
parent 89234b37a4
commit 722855caf7
2 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
mobile/src/main/java/be/mygod/vpnhotspot/net/IpNeighbour.kt
View File

@@ -23,31 +23,30 @@ data class IpNeighbour(val ip: InetAddress, val dev: String, val lladdr: String,
private fun checkLladdrNotLoopback(lladdr: String) = if (lladdr == "00:00:00:00:00:00") "" else lladdr private fun checkLladdrNotLoopback(lladdr: String) = if (lladdr == "00:00:00:00:00:00") "" else lladdr
fun parse(line: String): IpNeighbour? { fun parse(line: String): IpNeighbour? {
val match = parser.matchEntire(line)!! return try {
val ip = parseNumericAddress(match.groupValues[2]) val match = parser.matchEntire(line)!!
val dev = match.groupValues[4] val ip = parseNumericAddress(match.groupValues[2])
var lladdr = checkLladdrNotLoopback(match.groupValues[6]) val dev = match.groupValues[4]
// use ARP as fallback var lladdr = checkLladdrNotLoopback(match.groupValues[6])
if (dev.isNotEmpty() && lladdr.isEmpty()) lladdr = checkLladdrNotLoopback(arp() // use ARP as fallback
.asSequence() if (dev.isNotEmpty() && lladdr.isEmpty()) lladdr = checkLladdrNotLoopback(arp()
.filter { parseNumericAddress(it[ARP_IP_ADDRESS]) == ip && it[ARP_DEVICE] == dev } .asSequence()
.map { it[ARP_HW_ADDRESS] } .filter { parseNumericAddress(it[ARP_IP_ADDRESS]) == ip && it[ARP_DEVICE] == dev }
.singleOrNull() ?: "") .map { it[ARP_HW_ADDRESS] }
val state = if (match.groupValues[1].isNotEmpty() || lladdr.isEmpty()) State.DELETING else .singleOrNull() ?: "")
when (match.groupValues[10]) { val state = if (match.groupValues[1].isNotEmpty() || lladdr.isEmpty()) State.DELETING else
"", "INCOMPLETE" -> State.INCOMPLETE when (match.groupValues[10]) {
"REACHABLE", "DELAY", "STALE", "PROBE", "PERMANENT" -> State.VALID "", "INCOMPLETE" -> State.INCOMPLETE
"FAILED" -> State.FAILED "REACHABLE", "DELAY", "STALE", "PROBE", "PERMANENT" -> State.VALID
"NOARP" -> return null // skip "FAILED" -> State.FAILED
else -> throw IllegalArgumentException("Unknown state encountered: ${match.groupValues[10]}") "NOARP" -> return null // skip
} else -> throw IllegalArgumentException("Unknown state encountered: ${match.groupValues[10]}")
return IpNeighbour(ip, dev, lladdr, state) }
} IpNeighbour(ip, dev, lladdr, state)
fun parseNoThrow(line: String): IpNeighbour? = try { } catch (e: Exception) {
parse(line) Timber.w(IllegalArgumentException("Unable to parse line: $line", e))
} catch (e: Exception) { null
Timber.w(IllegalArgumentException("Unable to parse line: $line", e)) }
null
} }
private val spaces = " +".toPattern() private val spaces = " +".toPattern()

4
mobile/src/main/java/be/mygod/vpnhotspot/net/monitor/IpNeighbourMonitor.kt
View File

@@ -38,7 +38,7 @@ class IpNeighbourMonitor private constructor() : IpMonitor() {
override fun processLine(line: String) { override fun processLine(line: String) {
synchronized(neighbours) { synchronized(neighbours) {
val neighbour = IpNeighbour.parseNoThrow(line) ?: return val neighbour = IpNeighbour.parse(line) ?: return
val changed = if (neighbour.state == IpNeighbour.State.DELETING) val changed = if (neighbour.state == IpNeighbour.State.DELETING)
neighbours.remove(neighbour.ip) != null neighbours.remove(neighbour.ip) != null
else neighbours.put(neighbour.ip, neighbour) != neighbour else neighbours.put(neighbour.ip, neighbour) != neighbour
@@ -50,7 +50,7 @@ class IpNeighbourMonitor private constructor() : IpMonitor() {
synchronized(neighbours) { synchronized(neighbours) {
neighbours.clear() neighbours.clear()
neighbours.putAll(lines neighbours.putAll(lines
.map(IpNeighbour.Companion::parseNoThrow) .map(IpNeighbour.Companion::parse)
.filterNotNull() .filterNotNull()
.filter { it.state != IpNeighbour.State.DELETING } // skip entries without lladdr .filter { it.state != IpNeighbour.State.DELETING } // skip entries without lladdr
.associateBy { it.ip }) .associateBy { it.ip })