From 67ef49248da7efad391a000c8b0956f06f7cdd3c Mon Sep 17 00:00:00 2001 From: Mygod Date: Fri, 5 Apr 2019 09:40:28 +0800 Subject: [PATCH 1/2] Refine code style --- mobile/src/main/res/layout/listitem_manage.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mobile/src/main/res/layout/listitem_manage.xml b/mobile/src/main/res/layout/listitem_manage.xml index 277064e5..4451ae05 100644 --- a/mobile/src/main/res/layout/listitem_manage.xml +++ b/mobile/src/main/res/layout/listitem_manage.xml @@ -2,7 +2,6 @@ - @@ -42,7 +41,7 @@ android:id="@+id/offloadEnabled" android:layout_width="match_parent" android:layout_height="wrap_content" - android:visibility="@{data.offloadEnabled ? View.VISIBLE : View.GONE}" + android:visibility="@{data.offloadEnabled}" android:text="@string/tethering_manage_offload_enabled"/> From d3ec4fc2fcc92d532db73cbb5150c0c0758daf69 Mon Sep 17 00:00:00 2001 From: Mygod Date: Fri, 5 Apr 2019 10:36:02 +0800 Subject: [PATCH 2/2] Support changing repeater operating channel on Android 5 --- .../configuration/WifiApDialogFragment.kt | 21 +++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/configuration/WifiApDialogFragment.kt b/mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/configuration/WifiApDialogFragment.kt index ed61142b..85121bea 100644 --- a/mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/configuration/WifiApDialogFragment.kt +++ b/mobile/src/main/java/be/mygod/vpnhotspot/net/wifi/configuration/WifiApDialogFragment.kt @@ -4,7 +4,6 @@ import android.annotation.TargetApi import android.content.ClipData import android.content.DialogInterface import android.net.wifi.WifiConfiguration -import android.net.wifi.WifiConfiguration.AuthAlgorithm import android.os.Build import android.os.Parcelable import android.text.Editable @@ -20,6 +19,7 @@ import androidx.core.view.isGone import be.mygod.vpnhotspot.AlertDialogFragment import be.mygod.vpnhotspot.App.Companion.app import be.mygod.vpnhotspot.R +import be.mygod.vpnhotspot.RepeaterService import be.mygod.vpnhotspot.util.QRCodeDialog import be.mygod.vpnhotspot.util.toByteArray import be.mygod.vpnhotspot.util.toParcelable @@ -78,7 +78,7 @@ class WifiApDialogFragment : AlertDialogFragment= 23) { val bandOption = dialogView.band.selectedItem as BandOption @@ -110,7 +110,7 @@ class WifiApDialogFragment : AlertDialogFragment= 23) { + if (Build.VERSION.SDK_INT >= 23 || arg.p2pMode) dialogView.band.apply { bandOptions = mutableListOf().apply { if (arg.p2pMode) add(BandOption.BandAny) else { if (Build.VERSION.SDK_INT >= 28) add(BandOption.BandAny) @@ -119,11 +119,13 @@ class WifiApDialogFragment : AlertDialogFragment false } } + + override fun onClick(dialog: DialogInterface?, which: Int) { + super.onClick(dialog, which) + if (Build.VERSION.SDK_INT < 23 && which == DialogInterface.BUTTON_POSITIVE) { + RepeaterService.operatingChannel = (dialogView.band.selectedItem as BandOption).apChannel + } + } }