From ca6df74c3c005eaf9e9c62e6dd4f1c0d61b93de7 Mon Sep 17 00:00:00 2001 From: Mygod Date: Sat, 23 Jun 2018 17:56:11 +0800 Subject: [PATCH] Redirect error stream --- .../src/main/java/be/mygod/vpnhotspot/util/NoisySu.kt | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/mobile/src/main/java/be/mygod/vpnhotspot/util/NoisySu.kt b/mobile/src/main/java/be/mygod/vpnhotspot/util/NoisySu.kt index 6bd6af20..f031b8f2 100644 --- a/mobile/src/main/java/be/mygod/vpnhotspot/util/NoisySu.kt +++ b/mobile/src/main/java/be/mygod/vpnhotspot/util/NoisySu.kt @@ -2,7 +2,6 @@ package be.mygod.vpnhotspot.util import android.util.Log import be.mygod.vpnhotspot.App.Companion.app -import be.mygod.vpnhotspot.R import com.crashlytics.android.Crashlytics import java.io.IOException import java.io.InputStream @@ -16,20 +15,13 @@ fun loggerSuStream(command: String): InputStream? { val process = try { ProcessBuilder("su", "-c", command) .directory(app.deviceContext.cacheDir) + .redirectErrorStream(true) .start() } catch (e: IOException) { e.printStackTrace() Crashlytics.logException(e) return null } - thread("LoggerSU-error") { - val err = process.errorStream.bufferedReader().readText() - if (err.isNotBlank()) { - Crashlytics.log(Log.ERROR, NOISYSU_TAG, err) - Crashlytics.logException(SuFailure()) - app.toast(R.string.noisy_su_failure) - } - } return process.inputStream }