Only return valid entries in light mode
This commit is contained in:
@@ -11,6 +11,7 @@ import timber.log.Timber
|
||||
import java.io.File
|
||||
import java.io.FileNotFoundException
|
||||
import java.io.IOException
|
||||
import java.net.Inet4Address
|
||||
import java.net.InetAddress
|
||||
import java.net.NetworkInterface
|
||||
import java.net.SocketException
|
||||
@@ -35,7 +36,6 @@ data class IpNeighbour(val ip: InetAddress, val dev: String, val lladdr: MacAddr
|
||||
* Source: https://android.googlesource.com/platform/external/iproute2/+/4b9e917/lib/ll_map.c#152
|
||||
*/
|
||||
private val devFallback = "^if(\\d+)\$".toRegex()
|
||||
private fun checkLladdrNotLoopback(lladdr: String) = if (lladdr == "00:00:00:00:00:00") "" else lladdr
|
||||
|
||||
private fun populateList(base: IpNeighbour): List<IpNeighbour> {
|
||||
val devParser = devFallback.matchEntire(base.dev)
|
||||
@@ -49,42 +49,43 @@ data class IpNeighbour(val ip: InetAddress, val dev: String, val lladdr: MacAddr
|
||||
}
|
||||
|
||||
fun parse(line: String, fullMode: Boolean): List<IpNeighbour> {
|
||||
if (line.isBlank()) return emptyList()
|
||||
return try {
|
||||
return if (line.isBlank()) emptyList() else try {
|
||||
val match = parser.matchEntire(line)!!
|
||||
val ip = parseNumericAddress(match.groupValues[2]) // by regex, ip is non-empty
|
||||
val dev = match.groupValues[3] // by regex, dev is non-empty as well
|
||||
val state = if (match.groupValues[1].isNotEmpty()) State.DELETING else
|
||||
when (match.groupValues[7]) {
|
||||
"", "INCOMPLETE" -> State.INCOMPLETE
|
||||
"REACHABLE", "DELAY", "STALE", "PROBE", "PERMANENT" -> State.VALID
|
||||
"FAILED" -> {
|
||||
if (!fullMode) return populateList(IpNeighbour(ip, dev, MacAddressCompat.ALL_ZEROS_ADDRESS,
|
||||
State.DELETING)) // skip parsing lladdr to avoid requesting root
|
||||
State.FAILED
|
||||
}
|
||||
"NOARP" -> return emptyList() // skip
|
||||
else -> throw IllegalArgumentException("Unknown state encountered: ${match.groupValues[7]}")
|
||||
}
|
||||
var lladdr = checkLladdrNotLoopback(match.groupValues[5])
|
||||
// use ARP as fallback for IPv4
|
||||
if (lladdr.isEmpty()) lladdr = checkLladdrNotLoopback(arp()
|
||||
.asSequence()
|
||||
.filter { parseNumericAddress(it[ARP_IP_ADDRESS]) == ip && it[ARP_DEVICE] == dev }
|
||||
.map { it[ARP_HW_ADDRESS] }
|
||||
.singleOrNull() ?: "")
|
||||
val mac = try {
|
||||
MacAddressCompat.fromString(lladdr)
|
||||
} catch (e: IllegalArgumentException) {
|
||||
if (match.groups[4] == null) return emptyList()
|
||||
// for DELETING, we only care about IP address and do not care if MAC is not present
|
||||
if (state != State.DELETING) Timber.w(IOException("Failed to find MAC address for $line", e))
|
||||
MacAddressCompat.ALL_ZEROS_ADDRESS
|
||||
val state = if (match.groupValues[1].isNotEmpty()) State.DELETING else when (match.groupValues[7]) {
|
||||
"", "INCOMPLETE" -> State.INCOMPLETE
|
||||
"REACHABLE", "DELAY", "STALE", "PROBE", "PERMANENT" -> State.VALID
|
||||
"FAILED" -> State.FAILED
|
||||
"NOARP" -> return emptyList() // skip
|
||||
else -> throw IllegalArgumentException("Unknown state encountered: ${match.groupValues[7]}")
|
||||
}
|
||||
populateList(IpNeighbour(ip, dev, mac, state))
|
||||
var lladdr = MacAddressCompat.ALL_ZEROS_ADDRESS
|
||||
if (!fullMode && state != State.VALID) {
|
||||
// skip parsing lladdr to avoid requesting root
|
||||
return populateList(IpNeighbour(ip, dev, lladdr, State.DELETING))
|
||||
}
|
||||
if (match.groups[4] != null) try {
|
||||
lladdr = MacAddressCompat.fromString(match.groupValues[5])
|
||||
} catch (e: IllegalArgumentException) {
|
||||
Timber.w(IOException("Failed to find MAC address for $line", e))
|
||||
}
|
||||
// use ARP as fallback for IPv4, except for INCOMPLETE which by definition does not have arp entry,
|
||||
// or for DELETING, which we do not care about MAC not present
|
||||
if (ip is Inet4Address && lladdr == MacAddressCompat.ALL_ZEROS_ADDRESS && state != State.INCOMPLETE &&
|
||||
state != State.DELETING) try {
|
||||
lladdr = MacAddressCompat.fromString(arp()
|
||||
.asSequence()
|
||||
.filter { parseNumericAddress(it[ARP_IP_ADDRESS]) == ip && it[ARP_DEVICE] == dev }
|
||||
.map { it[ARP_HW_ADDRESS] }
|
||||
.singleOrNull() ?: throw IllegalArgumentException("singleOrNull"))
|
||||
} catch (e: IllegalArgumentException) {
|
||||
Timber.w(e)
|
||||
}
|
||||
populateList(IpNeighbour(ip, dev, lladdr, state))
|
||||
} catch (e: Exception) {
|
||||
Timber.w(IllegalArgumentException("Unable to parse line: $line", e))
|
||||
emptyList()
|
||||
emptyList<IpNeighbour>()
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user